Linting: Fix type errors in git module #203
Merged
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 93.23% 93.22% -0.02%
==========================================
Files 30 30
Lines 1375 1372 -3
==========================================
- Hits 1282 1279 -3
Misses 93 93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* always explicitly cast path strings into Path object so function calls are always valid
ByteOtter
force-pushed
the
lint/fix-git-module
branch
from
b99a45b to
d007ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses some issues with potentially invalid function calls in the
gitmodule.The issue arose from a post-fact check if the given
git_directoryparameter was an instance ofPathLike, raising an error if not and then going ahead and callingpathlibspecific function likeexists()on the parameter.git_directoryremained typed asstr | PathLikethough.This led to calls to
pathlib.Path-specific methods such as.exists(),.is_dir(), and.match()on values that Pyright could not guarantee were Path instances.This PR changes that behavior to always explicitly cast
git_directoryinto aPathobject; eliminating the need for the type checks.Which issue(s) this PR fixes:
Tracks #152